-
Notifications
You must be signed in to change notification settings - Fork 291
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Viewing an archived conversation should not automatically “unarc…
…hive” it (#15629) * fix: self leave conversation shouldn't be archieved automatically * fix: backup password hint * fix: refactor showConversation method * fix: don't unarchieve when an archieved conversation viewed and stay at archieve view * fix: don't unarchive when a new message is received * fix: open the archived view directly for archived conversation notification click * feat: select archived conversation * fix: call openConversations conditionally * feat: remove shouldunaricve function which removes unarchive on events like new message, member join * fix: remove double subscription of openConversation * feat: use archivedState property to determine conversation type * fix: remove unarchive on memeber join event * fix: pipeline test * Update src/script/notification/NotificationRepository.ts Co-authored-by: Thomas Belin <[email protected]> * fix: code review comments --------- Co-authored-by: Thomas Belin <[email protected]>
- Loading branch information
1 parent
154c054
commit dc9fef4
Showing
7 changed files
with
103 additions
and
297 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.