Skip to content

Commit

Permalink
Use 1px for 'min-size' layout rows to fix Firefox spacing issue (#4171)
Browse files Browse the repository at this point in the history
Fixes #4114. Credit to @bennothommo
  • Loading branch information
Ben Thomson authored and LukeTowers committed Feb 28, 2019
1 parent a89f1f1 commit 57f358b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion modules/backend/assets/css/october.css
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ body {font-family:-apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sa
.layout >.layout-row >.layout-cell.min-height {height:0}
.layout >.layout-row >.layout-cell.center {text-align:center}
.layout >.layout-row >.layout-cell.middle {vertical-align:middle}
.layout >.layout-row.min-size {height:0}
.layout >.layout-row.min-size {height:1px}
.layout >.layout-cell {display:table-cell;vertical-align:top;height:100%}
.layout >.layout-cell.layout-container,
.layout >.layout-cell .layout-container,
Expand Down Expand Up @@ -656,6 +656,7 @@ body.slim-container .layout .layout-container {padding-left:0 !important;padding
body.mainmenu-open {overflow:hidden;position:fixed}
.mainmenu-tooltip .tooltip-inner {font-size:13px;padding:6px 16px}
ul.mainmenu-nav {font-size:14px}
ul.mainmenu-nav li {}
ul.mainmenu-nav li .svg-icon {-webkit-backface-visibility:hidden;backface-visibility:hidden}
ul.mainmenu-nav li span.counter {display:block;position:absolute;top:.143em;right:0;padding:.143em .429em .214em .286em;background-color:#d9350f;color:#fff;font-size:.786em;line-height:100%;-webkit-border-radius:3px;-moz-border-radius:3px;border-radius:3px;opacity:1;filter:alpha(opacity=100);-webkit-transform:scale(1,);-ms-transform:scale(1,);transform:scale(1,);-webkit-transition:all 0.3s;transition:all 0.3s}
ul.mainmenu-nav li span.counter.empty {opacity:0;filter:alpha(opacity=0);-webkit-transform:scale(0,);-ms-transform:scale(0,);transform:scale(0,)}
Expand Down
4 changes: 2 additions & 2 deletions modules/backend/assets/less/layout/layout.less
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ body {
// Removed for performance reasons
//
// @import url(https://fonts.googleapis.com/css?family=Noto+Sans:400,400italic,700,700italic);
//
//
// body {
// font-family: 'Noto Sans', sans-serif;
// }
Expand Down Expand Up @@ -137,7 +137,7 @@ body {
}

&.min-size {
height: 0;
height: 1px;
}
}

Expand Down

0 comments on commit 57f358b

Please sign in to comment.