solution2.5.2.3.scala #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Roehler <[email protected]>
Signed-off-by: Andreas Roehler <[email protected]>
winitzki
reviewed
Sep 29, 2024
|
|
||
| def cubesReach1(x: Int): Boolean = { | ||
| val a = Cubes.cubes(x) | ||
| a.length == 1 |
There was a problem hiding this comment.
Why is this condition a.length == 1? The question was, whether the sequence of "cubes" ever reaches the number 1, not whether that sequence consists of a single element.
winitzki
reviewed
Sep 29, 2024
| } | ||
|
|
||
| def cubesReach1(x: Int): Boolean = { | ||
| val a = Cubes.cubes(x) |
There was a problem hiding this comment.
Warum hier Cubes.cubes(x) und nicht einfach cubes(x)? Die Funktion cubes wurde gerade definiert.
Signed-off-by: Andreas Roehler <[email protected]>
winitzki
reviewed
Sep 30, 2024
| val a = Cubes.cubes(x) | ||
| a.length == 1 | ||
| val a = cubes(x) | ||
| a.length == 1 && a(0) == 1 |
There was a problem hiding this comment.
Why is the condition a.length == 1 necessary?
There was a problem hiding this comment.
Here are some tests that I would suggest:
assert ( cubesReach1(20) == false )
assert ( cubesReach1(50) == false )
assert ( cubesReach1(100) == true )
assert ( cubesReach1(112) == true )
assert ( cubesReach1(114) == false )
assert ( cubesReach1(778) == true )For example, the sequence for 778 is [1198, 1243, 100, 1].
Signed-off-by: Andreas Roehler <[email protected]>
winitzki
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.