feat: `bring eventbridge` #42

skorfmann · 2023-12-22T21:02:53Z

This adds an EventBridge library.

This implements the simulator version on top of the cloud.Topic and adds a subset of the available filters, namely:

Wildcard Matching: For simplicity, a basic wildcard match where * can represent any sequence of characters.
Comparison Operations: string operations "begins with", "ends with", and "equals-ignore-case".

progress

simulator
tf-aws

sim view

eladb

very elegant!

eventbridge/README.md

eventbridge/lib.test.w

eventbridge/lib.w

BREAKING CHANGE: the `url()` and `inflightUrl()` methods have been removed in favor of a `url` property.

* chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * Update bedrock/README.md * Update bedrock/bedrock.w * Update bedrock/joke.test.w

* wip * Update github/lib.test.w * Update github/lib.test.w * updates * updates * updated README * ignore test due to winglang/wing#5408 * adding description to github/package.json * adding author to github/package.json --------- Co-authored-by: Eyal Keren <[email protected]>

* fix(github): mts to js files * fix(github): mts to js files * fix(github): mts to js files

…49)

* fix(github): using interface for credentials instead of cloud.secret * fix(github): can't compile to tf-aws, missing cloud.service * fix(github): can't compile to tf-aws, missing cloud.service

Set up GitHub releases. This will be used to set up a webhook that detects newly released packages from GitHub release events. Version bumped `postgres` for testing purposes

github-actions · 2024-02-06T06:04:54Z

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

skorfmann · 2024-02-29T23:01:21Z

Pretty much finished - it deploys to AWS as well. However, the test is not properly working for some reason I couldn't figure out.

The node hiding doesn't work anymore, due to some changes in the way the map is rendered. But I think it's still pretty good anyway.

To find all the quirks and implementation mismatches between sim / tf-aws some real-world dog-fooding would be great!

eventbridge/platform/sim/bus.w

eventbridge/platform/tf-aws/eventbridge.w

eventbridge/platform/sim/instance.w

Co-authored-by: Elad Ben-Israel <[email protected]>

eventbridge/lib.w

eventbridge/package.json

eventbridge/platform/aws/publish.js

eventbridge/platform/awscdk/eventbridge.w

eventbridge/platform/awscdk/helper.js

mergify · 2024-03-13T10:56:18Z

Thanks for contributing, @skorfmann! This PR will now be added to the merge queue, or immediately merged if eventbridge is up-to-date with main and the queue is empty.

eladb

cool stuff!

A few additional thoughts about api

eladb · 2024-03-13T12:50:27Z

eventbridge/README.md

+});
+
+new cloud.Function(inflight () => {
+  bus.putEvents([{


Would have made sense to be variadic (...) so the array is not needed:

Suggested change

bus.putEvents([{

bus.putEvents({

eladb · 2024-03-13T12:51:20Z

eventbridge/README.md

+
+let bus = new eventbridge.Bus();
+
+bus.subscribeFunction("github.pull-request.created", inflight (event) => {


Kind of feels like subscribeFunction should take a cloud.Function and this should be called onEvent

makes sense. do we need subscribeFunction ? seems redundant

Not required

skorfmann added 2 commits December 22, 2023 21:53

feat: bring eventbridge

c076325

Merge branch 'main' into eventbridge

456259d

eladb reviewed Dec 24, 2023

View reviewed changes

eventbridge/README.md Show resolved Hide resolved

eventbridge/lib.test.w Outdated Show resolved Hide resolved

eventbridge/lib.w Outdated Show resolved Hide resolved

eladb and others added 15 commits December 30, 2023 18:39

Merge branch 'main' into eventbridge

c316216

fix (#45)

52b9fe8

fix(websockets): fix token usage in simulator (#46)

2cd6d10

BREAKING CHANGE: the `url()` and `inflightUrl()` methods have been removed in favor of a `url` property.

chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment (#47)

aafd29b

* chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * chore(bedrock): replacing BEDROCK_DEV with isTestEnvironment * Update bedrock/README.md * Update bedrock/bedrock.w * Update bedrock/joke.test.w

fix(github): mts to js files (#48)

5c0d7b5

* fix(github): mts to js files * fix(github): mts to js files * fix(github): mts to js files

fix(github): using interface for credentials instead of cloud.secret (#…

2a18bad

…49)

fix(github): can't compile to tf-aws, missing cloud.service (#50)

c18f81b

* fix(github): using interface for credentials instead of cloud.secret * fix(github): can't compile to tf-aws, missing cloud.service * fix(github): can't compile to tf-aws, missing cloud.service

chore: set up GitHub releases (#51)

dfa0cb1

Set up GitHub releases. This will be used to set up a webhook that detects newly released packages from GitHub release events. Version bumped `postgres` for testing purposes

chore: mergify fixes (#52)

7ec95d7

chore: fix mergify conditions (#53)

ce2696d

chore: mergify fixing continued (#54)

9adcff4

chore: mergify fixes (#55)

6b9db75

chore: testing

0439bf9

fix: unit test regression (#56)

e4e9ae2

github-actions bot added the Stale label Feb 6, 2024

github-actions bot closed this Feb 13, 2024

skorfmann added 3 commits February 29, 2024 16:54

Merge branch 'main' into eventbridge

40c0f54

deployable version

0db1cc1

remove accidental commit

a97d641

skorfmann reopened this Feb 29, 2024

skorfmann marked this pull request as ready for review February 29, 2024 23:01

skorfmann removed the Stale label Feb 29, 2024

eladb requested changes Mar 1, 2024

View reviewed changes

eventbridge/platform/sim/bus.w Outdated Show resolved Hide resolved

eventbridge/platform/sim/bus.w Outdated Show resolved Hide resolved

eventbridge/platform/tf-aws/eventbridge.w Outdated Show resolved Hide resolved

staycoolcall911 reviewed Mar 3, 2024

View reviewed changes

eventbridge/platform/sim/instance.w Outdated Show resolved Hide resolved

eladcon and others added 5 commits March 7, 2024 12:12

Update eventbridge/platform/sim/bus.w

1d6e04c

Co-authored-by: Elad Ben-Israel <[email protected]>

wip

df57157

wip

7fbd3fa

wip

1861b0c

wip

e6b86c3

eladb approved these changes Mar 11, 2024

View reviewed changes

eladcon added 4 commits March 13, 2024 12:05

wip

9978071

wip

0a72274

wip

82df437

Merge branch 'main' into eventbridge

5ff5b76

mergify bot merged commit 794ecb9 into main Mar 13, 2024
5 checks passed

mergify bot deleted the eventbridge branch March 13, 2024 10:56

eladb reviewed Mar 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `bring eventbridge` #42

feat: `bring eventbridge` #42

skorfmann commented Dec 22, 2023 •

edited

Loading

eladb left a comment

github-actions bot commented Feb 6, 2024

skorfmann commented Feb 29, 2024

mergify bot commented Mar 13, 2024

eladb left a comment

eladb Mar 13, 2024

eladb Mar 13, 2024

eladcon Mar 13, 2024

eladb Mar 13, 2024


		let bus = new eventbridge.Bus();

		bus.subscribeFunction("github.pull-request.created", inflight (event) => {

feat: bring eventbridge #42

feat: bring eventbridge #42

Conversation

skorfmann commented Dec 22, 2023 • edited Loading

progress

sim view

eladb left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2024

skorfmann commented Feb 29, 2024

mergify bot commented Mar 13, 2024

eladb left a comment

Choose a reason for hiding this comment

eladb Mar 13, 2024

Choose a reason for hiding this comment

eladb Mar 13, 2024

Choose a reason for hiding this comment

eladcon Mar 13, 2024

Choose a reason for hiding this comment

eladb Mar 13, 2024

Choose a reason for hiding this comment

feat: `bring eventbridge` #42

feat: `bring eventbridge` #42

skorfmann commented Dec 22, 2023 •

edited

Loading