feat(stripe): added new winglib for stripe #279
Conversation
|
IIRC we have an API that lets you check if you're running in a wing test or not -- so you might be able to add some logic to set an environment variable differently by adding a conditional: bring cloud;
let isTest = nodeof(this).app.isTestEnvironment; // bool
new cloud.Function(inflight () => {
log(isTest); // "true" if this function is invoked in a wing test, "false" otherwise
});Something about this API feels clunky though, @eladb wondering if you have ideas for renaming or a better place to put this? |
| /// The secret key for Stripe as a string | ||
| secretKey: str?; | ||
| /// Secret key for Stripe as a Secret resource (recommended) | ||
| secretKeySecret: cloud.Secret?; |
There was a problem hiding this comment.
Looked at the OpenAPI example, I did mainly for testing to be honest. Being able to create a Stripe client without secrets defined just passing a string in, seems odd though.
I need to explore how tests mock the Secret resource....and understand this more.
|
Clunky is the understatement of the year... Maybe we can sugar |
Co-authored-by: Elad Ben-Israel <[email protected]>
Thanks will have a look. FWIW it does initially feel odd to me to change implementation code to add test cases in there, rather than somehow mock this stuff in the test itself? Does that make sense? Not sure if it's cos I'm coming from a TS/JS background this is what I expect, or if this is normally fine and to be expected? Do we expect our users to change libs/implementation code with test edge cases? |
I like it!
Mmm - I think I get what you mean, coupling the logic closer to the test definitions sounds like it might be a better place. I think the behavior you were expecting (where .env.test variables are automatically loaded) probably should be supported. Smells like a bug - could you open an issue for it? Perhaps we can try going forward with the changes proposed in winglang/wing#4601, so all environment variables are retrieved during preflight. Then if you want to customize the value of "IGNORE_STRIPE_WEBHOOK_VALIDATION", I think you should be customize it through either the bring cloud;
bring util;
// mylib.w
class Foo {
f: cloud.Function;
new() {
let key = util.tryEnv("IGNORE_VALIDATION");
this.f = new cloud.Function(inflight () => {
log(key ?? "nil");
});
}
pub inflight run() {
this.f.invoke();
}
}
// test.w
util.setEnv("IGNORE_VALIDATION", "true");
let f = new Foo();
test "my test" {
f.run(); // logs "true"
} |
|
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
|
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
Here is my first attempt at a winglib 🎆
Core features
Questions
/webhookendpoint to make it optional, but not sure if this is best or not?IGNORE_STRIPE_WEBHOOK_VALIDATIONin my wing test, is this possible? I want a test to set it tofalseso I can test my edge cases..?.env.testfile to set myIGNORE_STRIPE_WEBHOOK_VALIDATIONto true. This file did not get pick up by my tests when runningwing test, is this a bug? From what I read in the docs this is expected? Unless I misread!Would love some thoughts/advice, I created this to gain more understanding of wing, whilst also hopefully providing value to others with a new lib :)