Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifted mutables become immutable #211

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

yoav-steinberg
Copy link
Contributor

Fixes broken test and libs due to winglang/wing#6303

  • Lifted mutables become immutable, so we can't treat them an mutable.
  • Don't used std.Node it's not liftable - need to consider what to do with it, the correct way is to use the builtin nodeof().

Copy link

mergify bot commented Apr 24, 2024

Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if yoav/fixes_due_to_lift_unmuting is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 5e4c1e9 into main Apr 24, 2024
8 checks passed
@mergify mergify bot deleted the yoav/fixes_due_to_lift_unmuting branch April 24, 2024 18:13
@eladb
Copy link
Contributor

eladb commented Apr 28, 2024

This is very cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants