-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): cloud deployment fails if root directory contains spaces #7188
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-7188.fly.dev 🚀 Last Updated (UTC) 2024-10-01 14:15 |
BenchmarksComparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥🟥🟥⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-10-01 14:20 |
sdk test run: https://github.com/winglang/wing/actions/runs/11124550295 |
Signed-off-by: monada-bot[bot] <[email protected]>
another workflow run after a small change: https://github.com/winglang/wing/actions/runs/11127000644 |
fixes: #6465
terraformAsset can't handle file paths that contain spaces- so I created the bundle zip manually- ONLY if there's a spaced path- since it hurts the benchmarks a bit
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.