-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): resources can inherit UI components of children #7123
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! 🎉
|
Working on adding docs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I think this is something that should be handled in the Wing Console. I would keep it simple and basically just hoist all interaction panes of children onto their parents without much configuration.
At least as an initial step, I think it will address the use case with less friction.
Console preview environment is available at https://wing-console-pr-7123.fly.dev 🚀 Last Updated (UTC) 2024-09-13 18:37 |
BenchmarksComparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-09-13 18:43 |
Maybe only hoisting the interaction panes of children that aren't hidden? I think it's important we have some way for an application or library author to choose whether to "reveal" internal details like if they contain Redis caches or DynamoDB tables or S3 buckets inside. I think I like your idea, simply hoisting stuff everything feels like a sane default |
Closes #7110
As a proposed solution to #7110, this change makes it possible for a parent resource to inherit the UI of one of its children. A child can be configured as the "default" by giving it the ID of "Default" or "Resource"...
... or by explicitly setting setting the
defaultChild
on the resource's internalNode
:Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.