Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily pin dependency #7030

Closed
wants to merge 1 commit into from

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Aug 20, 2024

Workaround for TanStack/virtual#804

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner August 20, 2024 04:22
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-7030.fly.dev 🚀

Last Updated (UTC) 2024-08-20 04:31

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±0.56 58ms±0.58 -1ms (-0.97%)⬜
hello_world.test.w -t sim 416ms±6.44 437ms±14.96 +21ms (+4.93%)🟥
hello_world.test.w -t tf-aws 1534ms±19.05 1541ms±11.33 +7ms (+0.48%)⬜
jsii_big.test.w -t sim 3030ms±42.41 3026ms±22.68 -3ms (-0.11%)⬜
jsii_big.test.w -t tf-aws 3242ms±45.95 3241ms±26.91 -1ms (-0.03%)⬜
functions_1.test.w -t sim 425ms±6.04 411ms±4.39 -13ms (-3.12%)⬜
functions_1.test.w -t tf-aws 893ms±7.79 888ms±16.32 -5ms (-0.55%)⬜
empty.test.w -t sim 381ms±4.89 382ms±3.38 +1ms (+0.27%)⬜
empty.test.w -t tf-aws 636ms±4.04 636ms±5.63 -1ms (-0.1%)⬜
functions_10.test.w -t sim 525ms±10.73 497ms±10.5 -28ms (-5.36%)⬜
functions_10.test.w -t tf-aws 2272ms±10.29 2233ms±23.55 -39ms (-1.72%)⬜
jsii_small.test.w -t sim 393ms±6.85 394ms±5.18 +0ms (+0.07%)⬜
jsii_small.test.w -t tf-aws 647ms±6.55 645ms±6.14 -1ms (-0.2%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 57ms 60ms 1ms 1ms
hello_world.test.w -t sim 437ms 410ms 479ms 15ms 21ms
hello_world.test.w -t tf-aws 1541ms 1530ms 1582ms 11ms 16ms
jsii_big.test.w -t sim 3026ms 2984ms 3068ms 23ms 32ms
jsii_big.test.w -t tf-aws 3241ms 3156ms 3289ms 27ms 38ms
functions_1.test.w -t sim 411ms 399ms 419ms 4ms 6ms
functions_1.test.w -t tf-aws 888ms 861ms 944ms 16ms 23ms
empty.test.w -t sim 382ms 374ms 388ms 3ms 5ms
empty.test.w -t tf-aws 636ms 618ms 644ms 6ms 8ms
functions_10.test.w -t sim 497ms 468ms 514ms 11ms 15ms
functions_10.test.w -t tf-aws 2233ms 2161ms 2273ms 24ms 33ms
jsii_small.test.w -t sim 394ms 383ms 408ms 5ms 7ms
jsii_small.test.w -t tf-aws 645ms 631ms 660ms 6ms 9ms
Last Updated (UTC) 2024-08-20 04:37

@Chriscbr Chriscbr closed this Aug 20, 2024
@Chriscbr Chriscbr deleted the rybickic/pin-tanstack-react-virtual branch August 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants