Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): lsp preview indicates methods have zero params #6990

Merged
merged 1 commit into from
Aug 6, 2024

fix(lsp): indicate methods may have parameters

8f7b0bd
Select commit
Loading
Failed to load commit list.
Merged

fix(compiler): lsp preview indicates methods have zero params #6990

fix(lsp): indicate methods may have parameters
8f7b0bd
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Aug 6, 2024 in 0s

The pull request embarked with main (136c844) will be merged soon

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • #review-threads-unresolved=0 [🛡 GitHub branch protection]
  • branch-protection-review-decision=APPROVED [🛡 GitHub branch protection]
  • all of [📃 From pull request rule automatic merge]:
    • #approved-reviews-by>=1
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved=0
    • -approved-reviews-by~=author
    • -closed
    • -draft
    • -draft [📌 queue requirement]
    • -files=.mergify.yml
    • -label~=(🚧 pr/do-not-merge|⚠️ pr/review-mutation)
    • -merged
    • -title~=(?i)wip
    • base=main
    • branch-protection-review-decision=APPROVED
    • check-success=Quality Gate
    • check-success=Validate PR title
    • any of [📌 queue -> configuration change requirements]:
      • -mergify-configuration-changed
      • check-success=Configuration changed
    • any of [🔀 queue conditions]:
      • all of [📌 queue conditions of queue default]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • #review-threads-unresolved=0 [🛡 GitHub branch protection]
        • branch-protection-review-decision=APPROVED [🛡 GitHub branch protection]
        • any of [🛡 GitHub branch protection]:
          • check-success=Build
          • check-neutral=Build
          • check-skipped=Build
  • any of [🛡 GitHub branch protection]:
    • check-success=Build
    • check-neutral=Build
    • check-skipped=Build

Check-runs and statuses of the embarked pull request #6990:

Publish details
sdk-spec-test details
Analyze (javascript-typescript) details
Benchmark details
Build details
CodeQL — No new alerts in code changed by this pull requestdetails
Console Preview details
E2E / ubuntu + Node20 [1/2] details
E2E / ubuntu + Node20 [2/2] details
Quality Gate details
Test details
Validate PR title details
comment details