-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): confusing error when trying to use private constructor #6242
Conversation
Thanks for opening this pull request! 🎉
|
tools/hangar/__snapshots__/test_corpus/sdk_tests/bucket/get.test.w_test_sim.md
Outdated
Show resolved
Hide resolved
Console preview environment is available at https://wing-console-pr-6242.fly.dev 🚀 Last Updated (UTC) 2024-04-15 20:29 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-04-15 20:34 |
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.70.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet
Fixes #3331
Besides updating this error message, I also updated other error messages to standardize around the name "constructor". This is the name used most in the language reference, and it's probably the most familiar to users coming from TypeScript, so sticking to one terminology in our errors should help make the language feel more cohesive.
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.