-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update tree-sitter to latest #6231
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6231.fly.dev 🚀 Last Updated (UTC) 2024-04-14 14:23 |
BenchmarksComparison to Baseline ⬜⬜⬜⬜🟥⬜🟥⬜🟥⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-04-14 14:27 |
Note that this doesn't help downstream users, who will have their own tree-sitter version (necessarily so, since they need to generate parsers for multiple different grammars). This PR will unbreak nvim-treesitter (until the next breaking change; tree-sitter is in a bit of flux right now), but it's not really sustainable. Not sure how to deal with this better, though; just wanted to make a note of this. EDIT I worked around this in nvim-treesitter by skipping bindings when generating, so don't feel blocked by us. The general point still stands (downstream won't see the pin, so it's not 100% safe to rely on that). |
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.70.8. |
The primary goal of this PR is to update tree-sitter to the latest version. This resulted in:
tree-sitter-traversal
dependency is removed since it doesn't support newer versions of tree-sitter, so I just added some code for the equivalent functionalityMost of the new files here are a result of the binding regeneration and can kinda be ignored.
Side note: Also noticed that the automatic semicolon insertion hasn't been working for a while so I added a fix for that (see
lsp.ts
)By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.