Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): wing pack does not enforce using peerDependencies #6218

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

garysassano
Copy link
Collaborator

Closes #5470

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner April 12, 2024 04:20
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@garysassano garysassano changed the title fix(cli): enforce peerDepeendencies for winglibs fix(cli): enforce peerDependencies for winglibs Apr 12, 2024
@monadabot
Copy link
Contributor

monadabot commented Apr 12, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.59 60ms±1.9 +2ms (+3.16%)⬜
functions_1.test.w -t sim 400ms±22.47 396ms±6.56 -4ms (-1.05%)⬜
functions_1.test.w -t tf-aws 806ms±6.59 813ms±8.78 +7ms (+0.83%)⬜
hello_world.test.w -t sim 397ms±8.81 401ms±5.49 +4ms (+1.1%)⬜
hello_world.test.w -t tf-aws 1510ms±8.78 1523ms±11.54 +14ms (+0.91%)⬜
jsii_big.test.w -t sim 2771ms±10.36 2778ms±20.03 +8ms (+0.28%)⬜
jsii_big.test.w -t tf-aws 2982ms±6.32 2993ms±10.71 +11ms (+0.35%)⬜
functions_10.test.w -t sim 483ms±9.83 487ms±5.76 +4ms (+0.77%)⬜
functions_10.test.w -t tf-aws 1991ms±10.46 2007ms±11.93 +16ms (+0.82%)⬜
jsii_small.test.w -t sim 360ms±3.57 368ms±3.74 +8ms (+2.17%)⬜
jsii_small.test.w -t tf-aws 596ms±5.46 601ms±6.4 +5ms (+0.89%)⬜
empty.test.w -t sim 356ms±2.03 359ms±4.6 +3ms (+0.89%)⬜
empty.test.w -t tf-aws 583ms±4.47 592ms±4.42 +9ms (+1.54%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 58ms 67ms 2ms 3ms
functions_1.test.w -t sim 396ms 384ms 412ms 7ms 9ms
functions_1.test.w -t tf-aws 813ms 792ms 838ms 9ms 12ms
hello_world.test.w -t sim 401ms 386ms 414ms 5ms 8ms
hello_world.test.w -t tf-aws 1523ms 1504ms 1556ms 12ms 16ms
jsii_big.test.w -t sim 2778ms 2754ms 2851ms 20ms 28ms
jsii_big.test.w -t tf-aws 2993ms 2976ms 3027ms 11ms 15ms
functions_10.test.w -t sim 487ms 477ms 503ms 6ms 8ms
functions_10.test.w -t tf-aws 2007ms 1969ms 2028ms 12ms 17ms
jsii_small.test.w -t sim 368ms 362ms 375ms 4ms 5ms
jsii_small.test.w -t tf-aws 601ms 590ms 617ms 6ms 9ms
empty.test.w -t sim 359ms 346ms 370ms 5ms 6ms
empty.test.w -t tf-aws 592ms 583ms 599ms 4ms 6ms
Last Updated (UTC) 2024-04-12 17:47

apps/wing/src/commands/pack.ts Outdated Show resolved Hide resolved
apps/wing/src/commands/pack.ts Outdated Show resolved Hide resolved
@MarkMcCulloh MarkMcCulloh changed the title fix(cli): enforce peerDependencies for winglibs fix(cli): wing pack does not enforce using peerDependencies Apr 12, 2024
@garysassano garysassano force-pushed the gary/cli-pack-peers branch 2 times, most recently from d80f68f to 01d0ab5 Compare April 12, 2024 17:37
Copy link
Contributor

mergify bot commented Apr 12, 2024

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if gary/cli-pack-peers is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 12, 2024
@mergify mergify bot merged commit 39569f0 into main Apr 12, 2024
15 checks passed
@mergify mergify bot deleted the gary/cli-pack-peers branch April 12, 2024 17:57
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.70.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wing pack should enforce peerDependencies usage instead of regular dependencies
3 participants