Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: cloud snapshot tests #6044

Merged
merged 5 commits into from
Apr 3, 2024
Merged

rfc: cloud snapshot tests #6044

merged 5 commits into from
Apr 3, 2024

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Mar 24, 2024

An RFC for #5958.

A proposal for a feature that will capture a snapshot of the synthesis output from wing test to reduce regressions in cloud implementations.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

An RFC for #5958.

A proposal for a feature that will capture a snapshot of the synthesis output
from `wing test` to reduce regressions in cloud implementations.
@eladb eladb requested a review from a team as a code owner March 24, 2024 13:59
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@hasanaburayyan hasanaburayyan requested a review from a team March 26, 2024 16:02
@hasanaburayyan hasanaburayyan requested a review from a team April 2, 2024 15:30
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably needs to be more consideration intertwined with things like #5576. When we move forward on that we should take this snapshotting into account.

I think there's enough here to move forward though. Especially since the hard part of this is the snapshot implementation itself which probably won't care much about how/where the lines are drawn for what a test is.

docs/contributing/999-rfcs/2024-03-24-snapshot-tests.md Outdated Show resolved Hide resolved
docs/contributing/999-rfcs/2024-03-24-snapshot-tests.md Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Apr 3, 2024

Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb/snapshot-tests is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 3, 2024
@mergify mergify bot merged commit 9885935 into main Apr 3, 2024
5 checks passed
@mergify mergify bot deleted the eladb/snapshot-tests branch April 3, 2024 11:01
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.67.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants