Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): react vite template post install command #5972

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

ainvoner
Copy link
Contributor

command was failing on windows

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@ainvoner ainvoner requested a review from a team as a code owner March 18, 2024 12:49
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Mar 18, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.68 58ms±0.6 0ms (-0.31%)⬜
empty.test.w -t sim 496ms±17.68 481ms±4.17 -15ms (-3.05%)⬜
empty.test.w -t tf-aws 702ms±3.75 708ms±4.73 +6ms (+0.87%)⬜
hello_world.test.w -t sim 519ms±5.29 525ms±18.39 +6ms (+1.17%)⬜
hello_world.test.w -t tf-aws 1643ms±15.14 1647ms±11.38 +4ms (+0.24%)⬜
functions_10.test.w -t sim 590ms±5.96 587ms±9.37 -4ms (-0.6%)⬜
functions_10.test.w -t tf-aws 2211ms±11.09 2223ms±9.31 +11ms (+0.51%)⬜
jsii_small.test.w -t sim 487ms±3.69 493ms±4.66 +6ms (+1.22%)⬜
jsii_small.test.w -t tf-aws 707ms±5.96 710ms±4.04 +4ms (+0.5%)⬜
jsii_big.test.w -t sim 2887ms±10.3 2888ms±7.82 +1ms (+0.03%)⬜
jsii_big.test.w -t tf-aws 3106ms±15.06 3107ms±12.32 +1ms (+0.05%)⬜
functions_1.test.w -t sim 513ms±5.66 516ms±6.1 +3ms (+0.53%)⬜
functions_1.test.w -t tf-aws 938ms±6.16 944ms±6.07 +5ms (+0.57%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 58ms 60ms 1ms 1ms
empty.test.w -t sim 481ms 474ms 493ms 4ms 6ms
empty.test.w -t tf-aws 708ms 699ms 718ms 5ms 7ms
hello_world.test.w -t sim 525ms 504ms 594ms 18ms 26ms
hello_world.test.w -t tf-aws 1647ms 1624ms 1678ms 11ms 16ms
functions_10.test.w -t sim 587ms 568ms 605ms 9ms 13ms
functions_10.test.w -t tf-aws 2223ms 2192ms 2235ms 9ms 13ms
jsii_small.test.w -t sim 493ms 486ms 505ms 5ms 7ms
jsii_small.test.w -t tf-aws 710ms 704ms 718ms 4ms 6ms
jsii_big.test.w -t sim 2888ms 2877ms 2914ms 8ms 11ms
jsii_big.test.w -t tf-aws 3107ms 3088ms 3154ms 12ms 17ms
functions_1.test.w -t sim 516ms 503ms 530ms 6ms 9ms
functions_1.test.w -t tf-aws 944ms 935ms 966ms 6ms 8ms
Last Updated (UTC) 2024-03-18 13:31

@ainvoner ainvoner requested a review from skyrpex March 18, 2024 13:01
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thanks for contributing, @ainvoner! This PR will now be added to the merge queue, or immediately merged if fix-canary-react-vite is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 18, 2024
mergify bot added a commit that referenced this pull request Mar 18, 2024
@mergify mergify bot merged commit 8726c44 into main Mar 18, 2024
15 checks passed
@mergify mergify bot deleted the fix-canary-react-vite branch March 18, 2024 13:42
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants