Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add guide to consolidate lambdas for cold starts via platform #5668

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ekeren
Copy link
Collaborator

@ekeren ekeren commented Feb 11, 2024

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@monadabot
Copy link
Contributor

monadabot commented Feb 11, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @skorfmann
Wing Playground @eladcon

@eladcon eladcon changed the title feat(doc): add guide to consolidate lambdas for cold starts via platform feat(docs): add guide to consolidate lambdas for cold starts via platform Feb 11, 2024
@monadabot
Copy link
Contributor

monadabot commented Feb 11, 2024

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.6 61ms±0.71 +2ms (+4%)🟥
functions_10.test.w -t sim 514ms±9.82 514ms±18.57 +0ms (+0.08%)⬜
functions_10.test.w -t tf-aws 2186ms±20.96 2223ms±23.98 +37ms (+1.68%)⬜
hello_world.test.w -t sim 428ms±6.95 417ms±4.08 -11ms (-2.48%)⬜
hello_world.test.w -t tf-aws 1482ms±8.99 1502ms±16.81 +20ms (+1.35%)⬜
functions_1.test.w -t sim 412ms±6.5 426ms±7.66 +14ms (+3.37%)🟥
functions_1.test.w -t tf-aws 857ms±8.34 882ms±8.23 +25ms (+2.89%)⬜
jsii_big.test.w -t sim 2851ms±25.22 2858ms±23.19 +7ms (+0.24%)⬜
jsii_big.test.w -t tf-aws 3092ms±15.6 3089ms±19.09 -3ms (-0.1%)⬜
empty.test.w -t sim 379ms±4.51 380ms±3.77 +1ms (+0.35%)⬜
empty.test.w -t tf-aws 619ms±5.21 619ms±3.52 +0ms (+0.02%)⬜
jsii_small.test.w -t sim 398ms±7.71 384ms±3.57 -14ms (-3.53%)⬜
jsii_small.test.w -t tf-aws 638ms±7.5 631ms±7.25 -7ms (-1.14%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 61ms 60ms 63ms 1ms 1ms
functions_10.test.w -t sim 514ms 470ms 543ms 19ms 26ms
functions_10.test.w -t tf-aws 2223ms 2188ms 2287ms 24ms 34ms
hello_world.test.w -t sim 417ms 408ms 426ms 4ms 6ms
hello_world.test.w -t tf-aws 1502ms 1473ms 1554ms 17ms 24ms
functions_1.test.w -t sim 426ms 409ms 438ms 8ms 11ms
functions_1.test.w -t tf-aws 882ms 866ms 900ms 8ms 12ms
jsii_big.test.w -t sim 2858ms 2828ms 2919ms 23ms 32ms
jsii_big.test.w -t tf-aws 3089ms 3042ms 3115ms 19ms 27ms
empty.test.w -t sim 380ms 371ms 389ms 4ms 5ms
empty.test.w -t tf-aws 619ms 613ms 627ms 4ms 5ms
jsii_small.test.w -t sim 384ms 376ms 393ms 4ms 5ms
jsii_small.test.w -t tf-aws 631ms 609ms 645ms 7ms 10ms
Last Updated (UTC) 2024-06-04 10:58

Copy link
Contributor

@hasanaburayyan hasanaburayyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt get a chance to actually read the custom APi and custom Function resources yet but I love the concept.

docs/docs/08-guides/03-cold-start.md Outdated Show resolved Hide resolved
docs/docs/08-guides/03-cold-start.md Outdated Show resolved Hide resolved
{
restApiId: api.id,
resourceId: proxy.id,
authorization: "NONE",

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "NONE" is used as
authorization header
.
{
restApiId: api.id,
resourceId: api.rootResourceId,
authorization: "NONE",

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "NONE" is used as
authorization header
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants