feat(sdk): adding std.Map tests #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuf239
reviewed
Oct 1, 2023
|
@tsuf239 can you approve if you think it is ready? |
|
@WeepingClown13 great work!!! |
|
Thanks for contributing, @WeepingClown13! This PR will now be added to the merge queue, or immediately merged if |
14 tasks
|
Oh thanks. I just added another commit to add a comment about the mentioned bug and finished building it but sure😂 |
|
Congrats! 🚀 This was released in Wing 0.34.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first time I am writing tests, so admittedly my tests are not that versatile. But as I also believe that std tests should be straightforward, I do not totally mind it. Since
keys()andvalues()methods of maps seems to return an array that fails to assert "is the same as another array of same elements" (which seems to be a bug), I had to iterate over the array values and confirm it works as expected.closes: #4363
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.