Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add parseUrl() and formatUrl() to http submodule #4329

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

garysassano
Copy link
Collaborator

Closes #3332

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner September 28, 2023 19:18
@garysassano garysassano changed the title feat(sdk): add parseUrl() and formatUrl to http submodule feat(sdk): add parseUrl() and formatUrl() to http submodule Sep 28, 2023
@monadabot
Copy link
Contributor

monadabot commented Sep 28, 2023

Console preview environment is available at https://wing-console-pr-4329.fly.dev 🚀

Last Updated (UTC) 2023-09-29 17:57

@monadabot
Copy link
Contributor

monadabot commented Sep 28, 2023

Benchmarks

Results
name mean min max moe sd
version 87ms 85ms 91ms 3ms 4ms
functions_10.test.w -t sim 770ms 739ms 854ms 18ms 32ms
functions_10.test.w -t tf-aws 4683ms 4636ms 4762ms 20ms 37ms
jsii_big.test.w -t sim 4451ms 4385ms 4588ms 33ms 60ms
jsii_big.test.w -t tf-aws 4622ms 4558ms 4686ms 28ms 50ms
hello_world.test.w -t sim 673ms 640ms 698ms 8ms 14ms
hello_world.test.w -t tf-aws 5596ms 5486ms 5828ms 47ms 85ms
empty.test.w -t sim 634ms 613ms 700ms 13ms 23ms
empty.test.w -t tf-aws 796ms 780ms 828ms 9ms 15ms
jsii_small.test.w -t sim 626ms 611ms 644ms 6ms 11ms
jsii_small.test.w -t tf-aws 804ms 786ms 855ms 10ms 18ms
functions_1.test.w -t sim 710ms 686ms 773ms 12ms 22ms
functions_1.test.w -t tf-aws 2535ms 2308ms 2675ms 53ms 95ms
Comparison to main
Benchmark Before After Change
version 102ms±4.02 87ms±2.63 -15ms (-14.49%)🟩
functions_10.test.w -t sim 894ms±13.74 770ms±17.84 -124ms (-13.91%)🟩
functions_10.test.w -t tf-aws 5388ms±45.1 4683ms±20.45 -705ms (-13.09%)🟩
jsii_big.test.w -t sim 4895ms±59.82 4451ms±33.04 -444ms (-9.08%)🟩
jsii_big.test.w -t tf-aws 5176ms±73.13 4622ms±27.54 -554ms (-10.7%)🟩
hello_world.test.w -t sim 743ms±8.22 673ms±7.8 -70ms (-9.4%)🟩
hello_world.test.w -t tf-aws 6105ms±49.85 5596ms±46.98 -509ms (-8.35%)🟩
empty.test.w -t sim 679ms±7.25 634ms±12.55 -44ms (-6.55%)🟩
empty.test.w -t tf-aws 876ms±10.97 796ms±8.51 -80ms (-9.11%)🟩
jsii_small.test.w -t sim 698ms±8.88 626ms±6.05 -72ms (-10.27%)🟩
jsii_small.test.w -t tf-aws 871ms±11.34 804ms±10.09 -66ms (-7.63%)🟩
functions_1.test.w -t sim 776ms±13.39 710ms±12 -66ms (-8.55%)🟩
functions_1.test.w -t tf-aws 2723ms±62.36 2535ms±52.69 -187ms (-6.89%)🟩
Last Updated (UTC) 2023-09-29 18:04

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 28, 2023
libs/wingsdk/src/http/http.ts Show resolved Hide resolved
libs/wingsdk/src/http/http.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/http/http.ts Show resolved Hide resolved
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/http-url-util is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 2, 2023
@mergify mergify bot merged commit 926c3d4 into main Oct 2, 2023
15 checks passed
@mergify mergify bot deleted the garysassano/http-url-util branch October 2, 2023 07:21
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing utility to parse/format URLs
4 participants