-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): aws queue client does not delete popped messages #4314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the future I wonder if we should rework the Queue API to give the user a bit more control -- e.g. pop
could return you a Task
object that can be deleted from the queue with task.complete()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually had a couple of POCs on that track, but ended up dropping them. I think the current queue API is closer to the classic data structure interface, so I pivoted to match the simulator behavior. However, I definitely agree with you on the user control story, especially after seeing messages like "queue is not FIFO" in the code base. Queue API might need to re-position itself a bit between classic queue surface and its characteristic of being distributed in the cloud. |
Signed-off-by: monada-bot[bot] <[email protected]>
Ran the queue tests again, all passed 👍 |
Thanks for contributing, @flyingImer! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.33.24. |
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.