Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(console): address eslint warnings #4129

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore(console): address eslint warnings #4129

merged 2 commits into from
Oct 12, 2023

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Sep 9, 2023 •
edited
Loading

Solves #3903.

@monadabot
Copy link
Contributor

monadabot commented Sep 9, 2023 •
edited
Loading

Console preview environment is available at https://wing-console-pr-4129.fly.dev 🚀

Last Updated (UTC) 2023-10-12 07:52

@skyrpex skyrpex force-pushed the Address-ESLint-warnings-in-the-Console-codebase branch from c87d6d9 to 5572a9b Compare September 20, 2023 09:40
@skyrpex skyrpex marked this pull request as ready for review September 20, 2023 09:45
@MarkMcCulloh MarkMcCulloh mentioned this pull request Sep 26, 2023
Closed
@MarkMcCulloh
Copy link
Contributor

@skyrpex Anything blocking this PR? Would love to get rid of the warnings 🙏

It looks like there are still 2 warnings in the last build within this PR.

@skyrpex skyrpex force-pushed the Address-ESLint-warnings-in-the-Console-codebase branch from 358c4e8 to 0cb678e Compare October 12, 2023 07:39
@skyrpex
Copy link
Contributor Author

skyrpex commented Oct 12, 2023

No blockers AFAIK.

@skyrpex
Copy link
Contributor Author

skyrpex commented Oct 12, 2023

It looks like there are still 2 warnings in the last build within this PR.

Will check them out.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if Address-ESLint-warnings-in-the-Console-codebase is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 198b9de into main Oct 12, 2023
12 checks passed
@mergify mergify bot deleted the Address-ESLint-warnings-in-the-Console-codebase branch October 12, 2023 07:55
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.37.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@ainvoner ainvoner ainvoner approved these changes

@polamoros polamoros Awaiting requested review from polamoros

@eladcon eladcon Awaiting requested review from eladcon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skyrpex @monadabot @MarkMcCulloh @eladb @ainvoner