Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add variadic params to jsii docgen #4007

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

tsuf239
Copy link
Collaborator

@tsuf239 tsuf239 commented Aug 29, 2023

closes #3781
image

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@tsuf239 tsuf239 requested a review from a team as a code owner August 29, 2023 16:39
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/jsii-variadics is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 6, 2023
mergify bot added a commit that referenced this pull request Sep 6, 2023
@mergify mergify bot merged commit 52b44ca into main Sep 6, 2023
11 checks passed
@mergify mergify bot deleted the tsuf/jsii-variadics branch September 6, 2023 08:06
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.29.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for variadic parameters in jsii-docgen
3 participants