fix(compiler): error when more than one space is placed between if and let
#3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCulloh
approved these changes
Aug 24, 2023
MarkMcCulloh
changed the title
if and letif and let
MarkMcCulloh
changed the title
if and letif and let
marciocadev
changed the title
if and letif and let
MarkMcCulloh
changed the title
if and letif and let
|
@MarkMcCulloh, you were faster than I had imagined |
|
When I saw the issue you created and self-assigned, I knew what was about to happen :) |
|
Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if |
10 tasks
|
Congrats! 🚀 This was released in Wing 0.26.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarkMcCulloh, your review on PR #3888 made me realize that if I put more than one space between
if let, it generates errors.I've updated the
if letto work even with extra spaces.Closes #3959
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.