Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): improve JSII loading speed via binary format cache #3567

Merged
merged 43 commits into from
Aug 1, 2023
Merged

fix(compiler): improve JSII loading speed via binary format cache #3567

merged 43 commits into from
Aug 1, 2023

Commits on Jul 21, 2023

  1. msgpack caching of imported jsii manifests (performance)

    @yoav-steinberg
    yoav-steinberg committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4c9cccf View commit details
    Browse the repository at this point in the history

  2. fix gzipped jsii caching (fingerprint is hash on entire gz file)

    @yoav-steinberg
    yoav-steinberg committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6095527 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. use file metadata as cache fingerprint instead of jsii fingerprint 

    less assumptions and no need to unzip gzipped compressed manifesets in order to check if we have them cached
    @yoav-steinberg
    yoav-steinberg committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6c52403 View commit details
    Browse the repository at this point in the history

  2. dep cleanup

    @yoav-steinberg
    yoav-steinberg committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    5ef101e View commit details
    Browse the repository at this point in the history

  3. cleanup

    @yoav-steinberg
    yoav-steinberg committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    f6c233b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into yoav/jsii_bin_cache

    @yoav-steinberg
    yoav-steinberg committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    705054a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. use bincode instead of rmp_serde 

    To overcome bincode not supporting serde tagged enum deserialization we use bincode's own (non serde) Encode/Decode traits.
    @yoav-steinberg
    yoav-steinberg committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    d938a70 View commit details
    Browse the repository at this point in the history

  2. fix (type inference issue)

    @yoav-steinberg
    yoav-steinberg committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    5b9d653 View commit details
    Browse the repository at this point in the history

  3. optimization: remove unecessary clone of imported jsii assembly

    @yoav-steinberg
    yoav-steinberg committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    5594f06 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into yoav/jsii_bin_cache

    @yoav-steinberg
    yoav-steinberg committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    45c97f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge branch 'main' into yoav/jsii_bin_cache

    @yoav-steinberg
    yoav-steinberg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3c8560a View commit details
    Browse the repository at this point in the history

  2. use std::env::temp_dir() instead of assuming /tmp

    @yoav-steinberg
    yoav-steinberg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    010d8dd View commit details
    Browse the repository at this point in the history

  3. fix prev commit

    @yoav-steinberg
    yoav-steinberg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    be3eb90 View commit details
    Browse the repository at this point in the history

  4. use module version and name instead of path for manifest fingerprints 

    This is because there's no WASM support for path cononicalization. Beofre caching silently failed on WASM.
    @yoav-steinberg
    yoav-steinberg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    225041a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. store cache files by the .jsii manifest instead of temp dir 

    this is for wasm compatibility so we don't need `temp_dir()` access or canonical path calculation which aren't available in WASM.

Also added cleanup of old cache files or change detection
    @yoav-steinberg
    yoav-steinberg committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    614d99b View commit details
    Browse the repository at this point in the history

  2. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5173cdc View commit details
    Browse the repository at this point in the history

  3. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    604666f View commit details
    Browse the repository at this point in the history

  4. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0d9b4f2 View commit details
    Browse the repository at this point in the history

  5. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5c302b3 View commit details
    Browse the repository at this point in the history

  6. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6915966 View commit details
    Browse the repository at this point in the history

  7. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4f15004 View commit details
    Browse the repository at this point in the history

  8. Added test

    @yoav-steinberg
    yoav-steinberg committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8c39a30 View commit details
    Browse the repository at this point in the history

  9. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    73c4324 View commit details
    Browse the repository at this point in the history

  10. Update .gitignore 

    Co-authored-by: Mark McCulloh <[email protected]>
    @yoav-steinberg @MarkMcCulloh
    yoav-steinberg and MarkMcCulloh authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c1154dd View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. cleanup

    @yoav-steinberg
    yoav-steinberg committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e0bc422 View commit details
    Browse the repository at this point in the history

  2. parse JSON from memory instead of from File 

    this imporves performance, especially in WASM
    @yoav-steinberg
    yoav-steinberg committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    42a592d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. fix search dirs so we'll find the correct (dev) version of the sdk wh… 

    …en running in a dev env
    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    5436f6b View commit details
    Browse the repository at this point in the history

  2. tests

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    cac29db View commit details
    Browse the repository at this point in the history

  3. lockfile update

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    25c5890 View commit details
    Browse the repository at this point in the history

  4. udpate deps

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    2bc1eaa View commit details
    Browse the repository at this point in the history

  5. dbg

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    cb0a21a View commit details
    Browse the repository at this point in the history

  6. dbg

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    9361a63 View commit details
    Browse the repository at this point in the history

  7. dbg, cleanup, avoid race?

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    996e320 View commit details
    Browse the repository at this point in the history

  8. dbg

    @yoav-steinberg
    yoav-steinberg committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    29dba71 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. dbg

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    21ff82f View commit details
    Browse the repository at this point in the history

  2. dbg

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9bda699 View commit details
    Browse the repository at this point in the history

  3. correct path to wingsdk in test

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    1be22d3 View commit details
    Browse the repository at this point in the history

  4. revert debug stuff

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    aa4fc25 View commit details
    Browse the repository at this point in the history

  5. replace bincode with speedy (performance x2)

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    87026e4 View commit details
    Browse the repository at this point in the history

  6. typo

    @yoav-steinberg
    yoav-steinberg committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    4f4d80b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. cr, cleanup

    @yoav-steinberg
    yoav-steinberg committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    cc2c8c0 View commit details
    Browse the repository at this point in the history

  2. Fix color output in compiler

    @yoav-steinberg
    yoav-steinberg committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4f24ad1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into yoav/jsii_bin_cache

    @yoav-steinberg
    yoav-steinberg committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    18b33d0 View commit details
    Browse the repository at this point in the history