feat(compiler): support calling `super` methods #3468

yoav-steinberg · 2023-07-16T12:32:24Z

see #2986
This adds the ability to call the superclass's overridden methods from an extended class

class A { do() {}  }
class B extends A { 
  do() { 
    super.do(); // call A's "do" 
  }
}

Note that this currently doesn't support calling a super method from within an inflight closure (the complexity of capturing the parent's super after the closure is transformed into a class was too much.. see #3474).

Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

This is an automatic backport of pull request #3360 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Sebastian Korfmann <[email protected]>

Co-authored-by: Elad Ben-Israel <[email protected]>

This is an automatic backport of pull request #3403 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Eyal Keren <[email protected]>

This is an automatic backport of pull request #3419 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Ainvoner <[email protected]>

Co-authored-by: Hasan <[email protected]>

…d (backport #3428) (#3431) This is an automatic backport of pull request #3428 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Mark McCulloh <[email protected]>

Co-authored-by: Hasan <[email protected]>

Co-authored-by: Mark McCulloh <[email protected]>

…backport #3421) (#3437) Co-authored-by: Eyal Keren <[email protected]>

…backport #3436) (#3438) Co-authored-by: Uri Bar <[email protected]>

…3441) Co-authored-by: Hasan <[email protected]>

This is an automatic backport of pull request #3445 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Chris Rybicki <[email protected]>

This is an automatic backport of pull request #3452 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Hasan <[email protected]>

) This is an automatic backport of pull request #3460 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Ainvoner <[email protected]>

…3462) (#3463) This is an automatic backport of pull request #3462 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Ainvoner <[email protected]>

…3466) Co-authored-by: Eyal Keren <[email protected]>

Co-authored-by: Uri Bar <[email protected]>

Co-authored-by: Eyal Keren <[email protected]>

libs/wingc/src/type_check.rs

libs/wingc/src/jsify.rs

tools/hangar/__snapshots__/invalid.ts.snap

mergify · 2023-07-20T17:07:18Z

Thank you for contributing! Your pull request will be updated from dev and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

libs/wingc/src/type_check.rs

mergify · 2023-07-20T19:47:51Z

Thank you for contributing! Your pull request will be updated from dev and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2023-07-21T01:30:19Z

Thank you for contributing! Your pull request will be updated from dev and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

monadabot · 2023-07-21T16:07:59Z

Congrats! 🚀 This was released in Wing 0.24.41.

yoav-steinberg and others added 20 commits July 12, 2023 19:01

wip: super calls via new type of call expr

34479ea

chore: fix topic title (backport #3415) (#3416)

72d4d3c

Co-authored-by: Elad Ben-Israel <[email protected]>

fix(cli): removed duplicate export hook call (backport #3425) (#3429)

0de5447

Co-authored-by: Hasan <[email protected]>

fix(docs): analytic opt-out env var outdated (backport #3430) (#3433)

e3da1e5

Co-authored-by: Hasan <[email protected]>

chore: remove release commenter for now (backport #3427) (#3434)

cc2c8ed

Co-authored-by: Mark McCulloh <[email protected]>

chore(vscode): monada to wing cloud, and remove alpha from ext name (…

6c92e5b

…backport #3421) (#3437) Co-authored-by: Eyal Keren <[email protected]>

chore(docs): tf-aws cleanup bucket files and inflight docs enhanced (…

b55819c

…backport #3436) (#3438) Co-authored-by: Uri Bar <[email protected]>

fix(cli): display analytics disclaimer only in tty (backport #3439) (#…

d722833

…3441) Co-authored-by: Hasan <[email protected]>

wip

9abd0ba

wip

0767b48

added tests

2b9fbdf

snapshots

59d2472

yoav-steinberg linked an issue Jul 16, 2023 that may be closed by this pull request

Support calling super methods #2986

Closed

yoav-steinberg and others added 8 commits July 16, 2023 08:41

revert changes not needed

9be103f

chore(docs): modified compiler target code example (backport #3465) (#…

1b5fdab

…3466) Co-authored-by: Eyal Keren <[email protected]>

chore(docs): fix examples (backport #3471) (#3472)

9dbe1d6

Co-authored-by: Uri Bar <[email protected]>

fix(docs): typo in docs (backport #3467) (#3470)

bb3ffb6

Co-authored-by: Eyal Keren <[email protected]>

no need to track current class in jsifier (use this lookup instead)

2069141

reference issue in err message

86b47b8

Merge branch 'main' into yoav/super_calls2

0d68539

fixes after merge from main

5556bd4

yoav-steinberg marked this pull request as ready for review July 16, 2023 15:30

yoav-steinberg requested a review from a team as a code owner July 16, 2023 15:30

yoav-steinberg added 5 commits July 16, 2023 11:38

Merge branch 'dev' into yoav/super_calls2

0b1e4a2

import fixes after merge

4d31133

updated snapshot after merge

f5767d1

lint

e1d2798

Merge branch 'dev' into yoav/super_calls2

09c3b9d

MarkMcCulloh approved these changes Jul 19, 2023

View reviewed changes

libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved

libs/wingc/src/jsify.rs Show resolved Hide resolved

Chriscbr reviewed Jul 19, 2023

View reviewed changes

tools/hangar/__snapshots__/invalid.ts.snap Outdated Show resolved Hide resolved

tools/hangar/__snapshots__/invalid.ts.snap Outdated Show resolved Hide resolved

tools/hangar/__snapshots__/invalid.ts.snap Outdated Show resolved Hide resolved

yoav-steinberg added 2 commits July 20, 2023 12:25

cr: shorter err message

2779a94

cr: err messages

77c979b

mergify bot added a commit that referenced this pull request Jul 20, 2023

Merge of #3468

6f02c60

mergify bot mentioned this pull request Jul 20, 2023

merge queue: embarking dev (ce24a6a) and #3468 together #3545

Closed

8 tasks

mergify bot added a commit that referenced this pull request Jul 20, 2023

Merge of #3468

34bff8e

Chriscbr reviewed Jul 20, 2023

View reviewed changes

libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved

mergify bot mentioned this pull request Jul 20, 2023

merge queue: embarking dev (ce24a6a), #3468 and #3535 together #3546

Closed

8 tasks

fix: remove double wingc_env print

cd523c9

Merge branch 'dev' into yoav/super_calls2

d13b737

mergify bot merged commit 9b15965 into dev Jul 21, 2023
11 checks passed

mergify bot deleted the yoav/super_calls2 branch July 21, 2023 01:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compiler): support calling `super` methods #3468

feat(compiler): support calling `super` methods #3468

yoav-steinberg commented Jul 16, 2023 •

edited

Loading

mergify bot commented Jul 20, 2023

mergify bot commented Jul 20, 2023

mergify bot commented Jul 21, 2023

monadabot commented Jul 21, 2023

feat(compiler): support calling super methods #3468

feat(compiler): support calling super methods #3468

Conversation

yoav-steinberg commented Jul 16, 2023 • edited Loading

mergify bot commented Jul 20, 2023

mergify bot commented Jul 20, 2023

mergify bot commented Jul 21, 2023

monadabot commented Jul 21, 2023

feat(compiler): support calling `super` methods #3468

feat(compiler): support calling `super` methods #3468

yoav-steinberg commented Jul 16, 2023 •

edited

Loading