fix(compiler): panic when trying to import JSII constructs with no scope/id args #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constructs with no scope/id as first arg (like some in cdktf)
yoav-steinberg
changed the title
staycoolcall911
changed the title
Co-authored-by: Uri Bar <[email protected]>
|
@yoav-steinberg I think this might also resolve #1485, not totally sure |
Chriscbr
approved these changes
Jun 26, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Congrats! 🚀 This was released in Wing 0.22.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2934
Importing a construct from JSII that doesn't have a
scope/idarg pair as the first constructor arguments panicked the compiler. We now detect such (unconventional) constructs and mark them as so. This makes them non compatible with ouras/inkeywords for explicit scope/id control, but they can still be used by passing the correct (non standard) arguments to them.This resolves importing the cdktf library because its Backend constructs are an example of such non-standard constructs.
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.