-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): publish vscode extension when changed #2755
chore(build): publish vscode extension when changed #2755
Conversation
Hey @MarkMcCulloh second try here, since I saw an issue in the initial approach. |
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking another crack at this Fynn, and sorry for the big delay. I think this makes sense so lets give it a try!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Congrats! 🚀 This was released in Wing 0.22.26. |
Skips step
Publish Extension to Visual Studio Marketplace
in publish job if no changes made to VS Code extension. Adds step to fetch commit SHA of last successful workflow. The previous reverted solution missed to handle commits with failed jobs, in particular if there is new commit with cli changes once before the last one has finished and hence cancelled. That means it should always taken the diff against the lastest successful commit in account.Closes #2672.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.