Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): publish vscode extension when changed #2755

Conversation

fynnfluegge
Copy link
Collaborator

@fynnfluegge fynnfluegge commented Jun 1, 2023

Skips step Publish Extension to Visual Studio Marketplace in publish job if no changes made to VS Code extension. Adds step to fetch commit SHA of last successful workflow. The previous reverted solution missed to handle commits with failed jobs, in particular if there is new commit with cli changes once before the last one has finished and hence cancelled. That means it should always taken the diff against the lastest successful commit in account.

Closes #2672.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@fynnfluegge
Copy link
Collaborator Author

Hey @MarkMcCulloh second try here, since I saw an issue in the initial approach.
I added a step to the workflow to fetch the commit SHA of the last successful commit. The initial approach just calculated git diff against the previous commit which is not always correct since the workflow of that commit was cancelled or failed. I tested this here by switching the main branch to the-wing-trinity since there are several workflow failures and it gave me the correct SHA of the last successful commit which is 15ae922.
I think this approach seems promising now.

@fynnfluegge fynnfluegge marked this pull request as ready for review June 3, 2023 11:48
@fynnfluegge fynnfluegge requested a review from a team as a code owner June 3, 2023 11:48
@MarkMcCulloh MarkMcCulloh self-assigned this Jun 6, 2023
@github-actions
Copy link

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking another crack at this Fynn, and sorry for the big delay. I think this makes sense so lets give it a try!

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 44129c7 into winglang:main Jun 27, 2023
11 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.22.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants