Skip to content

Commit

Permalink
chore: skip std spec tests (#4504)
Browse files Browse the repository at this point in the history
## Description 
Currently, there are plenty of tests in a single file of any std test, and our current test scope (which duplicates resources by the number of tests) isn't handling it well, so we often get timeouts and exceptions.
Since the std tests' code is identical both on aws and the sim (and tested in the sim via hangar) I think we can skip it until the [testing issue](#3168) resolves.
link to test run: https://github.com/winglang/wing/actions/runs/6480615481

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
tsuf239 authored Oct 11, 2023
1 parent 7cf9c67 commit c83eaf7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ jobs:
with:
message: |
Console preview environment is available at https://${{env.APP_NAME}}.fly.dev :rocket:
###### Last Updated (UTC) ${{steps.deploy-fly.outputs.deploytime }}
comment_tag: Console preview environment
GITHUB_TOKEN: ${{secrets.PROJEN_GITHUB_TOKEN}}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tf-aws-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ jobs:
- name: Get list of directories and save them to the output
id: setdirs
shell: bash
run: |
dirs=$(ls -d examples/tests/sdk_tests/*/ | sed 's/\/$//' | grep -v "external" | jq -R -s -c 'split("\n")[:-1]')
run: | # TODO: skipping std and external folders, when https://github.com/winglang/wing/issues/3168 is resolve- we'll skip only the external folder.
dirs=$(ls -d examples/tests/sdk_tests/*/ | sed 's/\/$//' | grep -v "external\|std" | jq -R -s -c 'split("\n")[:-1]')
processed_dirs=$(echo "{ \"directory\": $dirs }" | jq -c '[ .directory[] | {directory: ., name: (split("/") | last)}]')
wrapped_dirs=$(echo "{ \"test\": $processed_dirs }" | jq -c .)
echo "dirs=$wrapped_dirs" >> $GITHUB_OUTPUT
Expand Down

0 comments on commit c83eaf7

Please sign in to comment.