Skip to content

Commit

Permalink
fix: flakey installation step in canary workflow (#4209)
Browse files Browse the repository at this point in the history
Fixes an operational issue with our canary workflow where installing the latest version of Winglang fails because npm reports a new version as the "latest" before it's actually available for download. (see https://github.com/winglang/wing/actions/runs/6224395212/job/16892506244)

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
Chriscbr authored Sep 18, 2023
1 parent 26bc6ad commit b71cae1
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,16 @@ jobs:
- 18
- 20
install_command:
- npm install -g winglang
- npm install -g winglang@latest
runs-on: ${{ matrix.runner }}
steps:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: Get Latest Wing Version
id: get-version
shell: bash
run: |
echo version=$(npm view winglang version) >> $GITHUB_OUTPUT
- name: Install Wing
run: |
${{ matrix.install_command }}@${{ steps.get-version.outputs.version }}
${{ matrix.install_command }}
- name: Download examples/tests/valid/test_bucket.main.w
run: |
curl -L https://raw.githubusercontent.com/winglang/wing/main/examples/tests/valid/test_bucket.main.w > test_bucket.main.w
Expand Down

0 comments on commit b71cae1

Please sign in to comment.