refactoring

winglang · Jul 19, 2023 · 9a5bef3 · 9a5bef3
1 parent a98c3e1
commit 9a5bef3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/libs/wingsdk/src/target-awscdk/schedule.ts b/libs/wingsdk/src/target-awscdk/schedule.ts
@@ -38,11 +38,15 @@ export class Schedule extends cloud.Schedule {
       let cronOpt: { [k: string]: string } = {
         minute: cronArr[0],
         hour: cronArr[1],
-        day: cronArr[2],
         month: cronArr[3],
-        weekDay: cronArr[4],
         year: "*",
       };
+      if (cronArr[2] !== "?") {
+        cronOpt.day = cronArr[2];
+      }
+      if (cronArr[4] !== "?") {
+        cronOpt.weekDay = cronArr[4];
+      }
 
       this.scheduleExpression = EventSchedule.cron(cronOpt);
     } else {

diff --git a/libs/wingsdk/test/target-awscdk/schedule.test.ts b/libs/wingsdk/test/target-awscdk/schedule.test.ts
@@ -152,4 +152,4 @@ test("cron with Day-of-month and Day-of-week setting with *", () => {
   ).toThrow(
     "cannot use * in both the Day-of-month and Day-of-week fields. If you use it in one, you must use ? in the other"
   );
-});
+});