Skip to content

Commit

Permalink
fix: missing built-in types in LSP auto-completion (#6296)
Browse files Browse the repository at this point in the history
## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
Chriscbr authored Apr 22, 2024
1 parent ec7e177 commit 7fad94a
Show file tree
Hide file tree
Showing 11 changed files with 61 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libs/wingc/src/lsp/completions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use crate::{UTIL_CLASS_NAME, WINGSDK_BRINGABLE_MODULES, WINGSDK_STD_MODULE};

use super::sync::check_utf8;

const BUILTIN_TYPES: [&str; 6] = ["bool", "duration", "Json", "MutJson", "num", "str"];
const BUILTIN_TYPES: [&str; 8] = ["bool", "duration", "Json", "MutJson", "num", "str", "datetime", "regex"];
const BUILTIN_GENERICS: [&str; 6] = ["Array", "Map", "MutArray", "MutMap", "MutSet", "Set"];

#[no_mangle]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
6 changes: 6 additions & 0 deletions libs/wingc/src/lsp/snapshots/completions/empty.snap
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down
6 changes: 6 additions & 0 deletions libs/wingc/src/lsp/snapshots/completions/type_parameter.snap
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,18 @@ source: libs/wingc/src/lsp/completions.rs
- label: bool
kind: 14
sortText: kl|zybool
- label: datetime
kind: 14
sortText: kl|zydatetime
- label: duration
kind: 14
sortText: kl|zyduration
- label: num
kind: 14
sortText: kl|zynum
- label: regex
kind: 14
sortText: kl|zyregex
- label: str
kind: 14
sortText: kl|zystr
Expand Down

0 comments on commit 7fad94a

Please sign in to comment.