revert: "cloud.ApiRequest.body is an empty string for GET requests" (…

…#6575) Reverts #6572
winglang · May 28, 2024 · 71bff40 · 71bff40
1 parent 1d09a8b
commit 71bff40
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 28 deletions.
diff --git a/examples/tests/sdk_tests/api/get.test.w b/examples/tests/sdk_tests/api/get.test.w
@@ -10,7 +10,7 @@ let body = "ok!";
 api.get("/path", inflight (req: cloud.ApiRequest): cloud.ApiResponse => {
   assert(req.method == cloud.HttpMethod.GET);
   assert(req.path == "/path");
-  assert(req.body == nil);
+  assert(req.body?.length == 0);
   assert(req.headers?.get("content-type") == "application/json");
 
   return cloud.ApiResponse {

diff --git a/examples/tests/sdk_tests/api/options.test.w b/examples/tests/sdk_tests/api/options.test.w
@@ -9,7 +9,7 @@ let path = "/path";
 api.options(path, inflight (req: cloud.ApiRequest): cloud.ApiResponse => {
   assert(req.method == cloud.HttpMethod.OPTIONS);
   assert(req.path == path);
-  assert(req.body == nil);
+  assert(req.body?.length == 0);
 
   return cloud.ApiResponse {
     status: 204
@@ -19,7 +19,7 @@ api.options(path, inflight (req: cloud.ApiRequest): cloud.ApiResponse => {
 api.head(path, inflight (req: cloud.ApiRequest): cloud.ApiResponse => {
   assert(req.method == cloud.HttpMethod.HEAD);
   assert(req.path == path);
-  assert(req.body == nil);
+  assert(req.body?.length == 0);
 
   return cloud.ApiResponse {
     status: 204

diff --git a/libs/wingsdk/src/target-sim/api.inflight.ts b/libs/wingsdk/src/target-sim/api.inflight.ts
@@ -314,7 +314,7 @@ export class Api
 function transformRequest(req: express.Request): ApiRequest {
   return {
     headers: sanitizeParamLikeObject(req.headers),
-    body: Object.keys(req.body).length > 0 ? req.body : undefined,
+    body: Object.keys(req.body).length > 0 ? req.body : "",
     method: parseHttpMethod(req.method),
     path: req.path,
     query: sanitizeParamLikeObject(req.query as any),