Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding auth and invite form #93

Closed
wants to merge 10 commits into from
Closed

feat: adding auth and invite form #93

wants to merge 10 commits into from

Conversation

mbonig
Copy link
Contributor

@mbonig mbonig commented Nov 17, 2022

This PR addresses most of the points in #91, specifically that it re-introduces the authentication that is required to see the docs. The following points have all been hit with this PR:

  • Same header and footer like the docs site
  • text explaining that only preview users can see winglang docs
  • login with github
  • get early preview CTA (embedded typeform) - See instructions in comment

If he is already authenticated but not authorised (not part of contributors / maintainers) he should see:

  • Same header and footer like the docs site
  • text explaining that only preview users can see winglang docs
  • get early preview CTA (embedded typeform) - See instructions in comment

Preview site is available here: https://website-git-auth-monada.vercel.app/

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website ✅ Ready (Inspect) Visit Preview Nov 19, 2022 at 2:21AM (UTC)

<BrowserOnly>
{
() => {
return <Auth0Provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-11-18 at 10 43 43

it tries to authorize mbonig

Copy link
Contributor Author

@mbonig mbonig Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'll double check and see what's going on. thanks for catching this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @skyrpex already took care of it with the new auth0 org account. will check as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbonig perhaps you can use this gitgub app instead of your own github user:
https://github.com/organizations/winglang/settings/applications/2045167

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently using the wingbot user.

if (!user) {
return false;
}
let roles = user["https://winglang.io/roles"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets check if the user is part of our winglang/wing Contributors or Maintainers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This role is applied at auth0 level. When a user logs in we take a look at the roles they have applied to their user in auth0 and expose that as this claim. These roles will be added based on their GH team registration (right now it's by Pipedrive deal)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw that you already updated it to look for the user in github teams

@ainvoner
Copy link
Contributor

We need @amielpb to help design the docs landing page so it will "speak" the same language as Guts website... (there will be a direct link between the website and the docs site)

@ainvoner
Copy link
Contributor

@skyrpex a new account in auth0 and added credentials to 1password

@mbonig
Copy link
Contributor Author

mbonig commented Nov 18, 2022

fixes #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants