only public workloads should be use NODE_PORT

winglang · Oct 9, 2023 · 65c783b · 65c783b
1 parent 8cf8b0a
commit 65c783b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/test/containers.test.w b/test/containers.test.w
@@ -7,7 +7,7 @@ let hello = new containers.Workload(
   image: "paulbouwer/hello-kubernetes:1",
   port: 8080,
   readiness: "/",
-  replicas: 4,
+  replicas: 3,
   env: {
     "MESSAGE" => message,
   },

diff --git a/tf-aws/workload.w b/tf-aws/workload.w
@@ -71,12 +71,19 @@ class _Chart extends k8s.Chart {
       }
     );
 
+    let isPublic = props.public ?? false;
+    let var serviceType: cdk8s.ServiceType? = nil;
+
+    if isPublic {
+      serviceType = cdk8s.ServiceType.NODE_PORT;
+    }
+
     let service = deployment.exposeViaService(
       name: name,
-      serviceType: cdk8s.ServiceType.NODE_PORT,
+      serviceType: serviceType,
     );
 
-    if (props.public ?? false) {
+    if isPublic {
       new cdk8s.Ingress(
         metadata: {
           name: name,