Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle edge case of /* // inside strings caught as unclosed comment #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qgates
Copy link

@qgates qgates commented Aug 7, 2023

removeComments() considers an attribute like accept="image/*" as an opening /* comment; worse, it never closes so everything following /* is removed. Fix regex to ignore /* and // inside strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant