Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow templates to be added as resolved Views #55

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jul 30, 2023

Also as fully-formed ModelAndView, or (as before) as view name String to be resolved later.

See #53

@wimdeblauwe
Copy link
Owner

There seems to be a merge conflict

@wimdeblauwe
Copy link
Owner

@odrotbohm anything you want to add here? As this was mainly your code :)

@dsyer dsyer force-pushed the mav branch 3 times, most recently from 3f036d0 to 7821fa0 Compare July 31, 2023 07:06
@odrotbohm
Copy link
Contributor

I like what I see, as, IIUC, this should allow dedicated models per template (fragment) rendered?

@dsyer
Copy link
Contributor Author

dsyer commented Jul 31, 2023

Yes, that was one of the goals.

@dsyer
Copy link
Contributor Author

dsyer commented Aug 1, 2023

(Added some tests)

@wimdeblauwe wimdeblauwe added this to the 2.2.0 milestone Aug 1, 2023
@wimdeblauwe
Copy link
Owner

Maybe we should update the README.md to explain those new usages as well? (See section https://github.com/wimdeblauwe/htmx-spring-boot-thymeleaf#oob-swap-support)

@dsyer
Copy link
Contributor Author

dsyer commented Aug 2, 2023

Done

README.md Outdated Show resolved Hide resolved
Also as fully-formed ModelAndView, or (as before) as view name String
to be resolved later.
@wimdeblauwe
Copy link
Owner

Thank you for your contribution!

@wimdeblauwe wimdeblauwe merged commit 6e6647f into wimdeblauwe:main Aug 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants