Added support for topic based exchanges and multiple consumers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topic exchanges can be used. Due to the way amqp.py declares the exchange in multiple locations, exchange_type needs to be passed around in quite a few places. Changed consumer tag and queue name so they are based on the exchange name and routing key. The previous method of just using the exchange name meant there could only be one consumer per exchange.
a topic exchange. Added RabbitMQ spec file to .gitignore.
|
Not just you should give type argument, all params behind exchange declare must be give |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use topic-based exchanges, so I removed the hard-coded 'type="direct"' exchange declarations. It will default to "direct" if no exchange_type is specified.
I also added an examples dir with a file showing how to use a topic-based exchange with txamqp to help people get up and running quickly.