Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow for use with PHP8 #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gforsythe-godaddy
Copy link

Previous code had a method named "match" which is now a restricted name.

@gforsythe-godaddy
Copy link
Author

@willdurand (or any other maintainers) any chance at pulling this?

@Nayte91
Copy link

Nayte91 commented Mar 31, 2023

Hello @willdurand can we accept this change? This is a very simple one that fixes few bugs for a very cheap cost.

Note that this bug still exist:
PHP Parse error: syntax error, unexpected token "match" in /home/akeneo/akeneo/pim-releases/20221223101040Z/vendor/willdurand/negotiation/src/Negotiation/Negotiator.php on line 41
PHP 8.0.26 / Akeneo 6.0.71 / rest-bundle 3.0.5 / negociation 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants