Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Type Hinting and Object Model #117

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Improvements to Type Hinting and Object Model #117

wants to merge 13 commits into from

Commits on Feb 15, 2022

  1. Depend on PHPUnit for development 

    In order to run the unit tests, PHPUnit is a hard dev
dependency, so I've included it in this commit, and now
I can run the unit tests as part of this PR.
    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    0d914a0 View commit details
    Browse the repository at this point in the history

  2. Depend on PHPStan for development 

    This is for willdurand#89 - to ensure correct type hints are provided
to developers who use IDEs.
    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    d8a356a View commit details
    Browse the repository at this point in the history

  3. Fix object model of AcceptHeader interface 

    Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation
    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    e3d8b4c View commit details
    Browse the repository at this point in the history

  4. Correct return type

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    c641a91 View commit details
    Browse the repository at this point in the history

  5. Correct nonexistent Priority class to AcceptHeader

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    56a1407 View commit details
    Browse the repository at this point in the history

  6. Improve typehint - allow looser type to be returned

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    90bc8cb View commit details
    Browse the repository at this point in the history

  7. Improve typehint - more accurate types as parameters

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    ba44a7a View commit details
    Browse the repository at this point in the history

  8. Improve typehint - more accurate generics as parameters

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    d13b8ca View commit details
    Browse the repository at this point in the history

  9. Expose script property - was only ever written

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    fc3ca90 View commit details
    Browse the repository at this point in the history

  10. Properly typehint associative array

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    df2623f View commit details
    Browse the repository at this point in the history

  11. Typehint nullable string

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    a00546f View commit details
    Browse the repository at this point in the history

  12. Match typehints of parent method

    @g105b
    g105b committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    b453ccd View commit details
    Browse the repository at this point in the history

  13. Run PHPStan as Github Action (#2) 

    * Depend on PHPUnit for development

In order to run the unit tests, PHPUnit is a hard dev
dependency, so I've included it in this commit, and now
I can run the unit tests as part of this PR.

* Depend on PHPStan for development

This is for willdurand#89 - to ensure correct type hints are provided
to developers who use IDEs.

* Fix object model of AcceptHeader interface

Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation

* Correct return type

* Correct nonexistent Priority class to AcceptHeader

* Improve typehint - allow looser type to be returned

* Improve typehint - more accurate types as parameters

* Improve typehint - more accurate generics as parameters

* Expose script property - was only ever written

* Properly typehint associative array

* Typehint nullable string

* Match typehints of parent method

* Add PHPStan to CI

* Configure PHPUnit versions for different PHP runtimes

* Use real phpunit
    @g105b
    g105b authored Feb 15, 2022
    Configuration menu
    Copy the full SHA
    91a9d73 View commit details
    Browse the repository at this point in the history