Migrate to gradle.kts (Gradle Kotlin DSL)
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making new file... otherwise intellij doesn't show syntax highlighting (it needs a successful compile first...)
Almost there.... TODO: - test-sets - spotbugs config - plugins DSL
But still using 'apply' syntax for 'subprojects'... not sure if this is the best way for multi-project setup? Any examples to copy?? Btw need `java-library` plugin to get extension methods such as `implementation`. Groovy doesn't need it because it's dynamic: unbroken-dome/gradle-testsets-plugin#109 (comment)
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2 2
===========================================
Files 1 1
Lines 4 4
===========================================
Hits 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
will-molloy
commented
Jul 1, 2023
Plugin config not working in `subprojects` block: unbroken-dome/gradle-testsets-plugin#109 (comment) So applying it in the subproject `build.gradle.kts`... means duplicate code if there's more than 1 subproject... There are other ways to register `integrationTest` task: https://stackoverflow.com/questions/52904603/integration-tests-with-gradle-kotlin-dsl But it's a lot more code, and none of them add `jacoco` for free.
will-molloy
commented
Jul 1, 2023
will-molloy
added a commit
to will-molloy/auto-handbrake-encoding
that referenced
this pull request
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit painful!
Closes #232