Spotbugs config

will-molloy · Jul 1, 2023 · d5156fa · d5156fa
1 parent 27adc58
commit d5156fa
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,4 +1,6 @@
 import com.diffplug.gradle.spotless.SpotlessExtension
+import com.github.spotbugs.snom.Confidence
+import com.github.spotbugs.snom.Effort
 import com.github.spotbugs.snom.SpotBugsExtension
 import com.github.spotbugs.snom.SpotBugsTask
 import org.gradle.api.tasks.testing.logging.TestExceptionFormat
@@ -49,14 +51,17 @@ subprojects {
   }
 
   // SpotBugs (static analysis - find possible bugs, performance issues etc.)
+  // TODO working? test on another project
   apply(plugin = "com.github.spotbugs")
   configure<SpotBugsExtension> {
-    // TODO
+    effort.set(Effort.MAX)
+    reportLevel.set(Confidence.LOW)
+    ignoreFailures.set(false)
+    excludeFilter.set(rootProject.file("./spotbugs-exclude.xml"))
   }
   tasks.withType<SpotBugsTask> {
-    reports {
-      // TODO
-    }
+    reports.create("xml").required.set(true)
+    reports.create("html").required.set(true)
   }
 
   tasks.withType<Test> {

diff --git a/hello-world/src/main/java/com/willmolloy/HelloWorld.java b/hello-world/src/main/java/com/willmolloy/HelloWorld.java
@@ -8,11 +8,11 @@
  *
  * @author <a href=https://willmolloy.com>Will Molloy</a>
  */
-public class HelloWorld {
+class HelloWorld {
 
   private final Logger log = LogManager.getLogger();
 
-  public String hello(String text) {
+  String hello(String text) {
     log.debug("Hello {}!", text);
     return "Hello %s!".formatted(text);
   }

diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -1,9 +1,4 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <FindBugsFilter>
 
-  <!-- False positive with records -->
-  <Match>
-    <Bug pattern="EQ_UNUSUAL" />
-  </Match>
-
 </FindBugsFilter>