Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix release CI #301

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

atmorling
Copy link
Contributor

Closes #297
yet to be tested in anger

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.55%. Comparing base (55e989a) to head (0f3de4e).
Report is 32 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #301       +/-   ##
===========================================
- Coverage   73.61%   63.55%   -10.06%     
===========================================
  Files          29       30        +1     
  Lines        2240     2434      +194     
===========================================
- Hits         1649     1547      -102     
- Misses        591      887      +296     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +70 to +72
extra:
recipe-maintainers:
- cisaacstern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atmorling take credit here!

Copy link
Contributor

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Per sync conversation, follow-ons include:

  • Remove ecoscope-core publish recipe from workflows
  • Move lonboard and earthranger-client recipes into separate repo (with workflow dispatch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GH Actions flow to release a build to prefix
3 participants