Skip to content

Commit

Permalink
code review applied
Browse files Browse the repository at this point in the history
  • Loading branch information
davidovichmarcos committed Aug 16, 2024
1 parent a1e46ca commit 9522c0c
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/_tests.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
name: Run tests
name: Run notebook tests
on:
push:
branches: [ "master" ]
pull_request:
branches: [ "*" ]
env:
ER_USERNAME: ${{ secrets.ER_USERNAME }}
ER_PASSWORD: ${{ secrets.ER_PASSWORD }}
GCP_DATAFLOW_SERVICE_KEY: ${{ secrets.GCP_DATAFLOW_SERVICE_KEY }}
GEE_SERVICE_ACCOUNT_KEY: ${{ secrets.GEE_SERVICE_ACCOUNT_KEY }}

jobs:
run_unit_tests:
Expand All @@ -14,7 +16,7 @@ jobs:
- name: 'Authenticate to Google Cloud'
uses: 'google-github-actions/auth@v1'
with:
credentials_json: '${{ secrets.GCP_DATAFLOW_SERVICE_KEY }}'
credentials_json: '${{ secrets.GEE_SERVICE_ACCOUNT_KEY }}'
- name: 'Set up Cloud SDK'
uses: 'google-github-actions/setup-gcloud@v1'
- name: Checkout branch
Expand All @@ -33,4 +35,4 @@ jobs:
env:
ER_USERNAME: ${{ secrets.ER_USERNAME }}
ER_PASSWORD: ${{ secrets.ER_PASSWORD }}
GCP_DATAFLOW_SERVICE_KEY: ${{ secrets.GCP_DATAFLOW_SERVICE_KEY }}
GEE_SERVICE_ACCOUNT_KEY: ${{ secrets.GEE_SERVICE_ACCOUNT_KEY }}

0 comments on commit 9522c0c

Please sign in to comment.