fix the datasources example #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `datasources-subsystem` example no longer exists. Instead, the `datasources-war` example is used. That example, however, needs to be started in one of 3 profiles; the default profile doesn't include any datasource and so the example doesn't work. To be able to do this, this commit adds the ability to specify arguments to the `java -jar *-swarm.jar` commands in a special file called `swarm-app-args.properties`.
Triggering the GC multiple times makes the results slightly more reliable.
heiko-braun
approved these changes
Feb 28, 2018
|
@Ladicek Let me know once you some recent number for a 2018.x release. I'd be curious to see how that compares previous versions |
|
Actually just working on comparison between 2018.2.0 and current master, to see if there were any regressions after the temp files leak fix. |
juangon
reviewed
Feb 28, 2018
| Jcmd.gc(pid); | ||
| for (int i = 0; i < 10; i++) { | ||
| Jcmd.gc(pid); | ||
| } |
There was a problem hiding this comment.
My very non-scientific experience is that 1 GC cycle isn't enough to collect everything. I'm not sure if we have many objects with finalizers (or in reference queues), but that's one reason why at least 2 GC cycles are required to clean up properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.