Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for settings.xml #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jcordes73
Copy link

Now in a source project a settings.xml can be provided in the configuration folder similar to JBoss EAP and JBoss Fuse xPaaS images.

@kenfinnigan
Copy link
Contributor

I'm not sure these changes are appropriate given that they're related to Red Hat products.

WildFly Swarm is not a product, only an upstream project.

@jcordes73
Copy link
Author

It should be implemented irrespective of community or enterprise, these were just examples. The same is done also for the WildFly STI. Otherwise builds just take too long on OpenShift.

@kenfinnigan
Copy link
Contributor

But you've added profiles for eap repositories, etc.

What is the main reason for needing settings.xml?

@jcordes73
Copy link
Author

I can remove the enterprise repos. The benefits of being able to provide Maven settings are:

  • Faster build times (from minutes to seconds)
  • Ability to provide grouping of repositories
  • Ability to provide proxy settinhs

@jcordes73
Copy link
Author

So you can disregard this pull request, I will send an enhanced version with the clean-up on the repos later.

@kenfinnigan
Copy link
Contributor

What is it about a settings.xml that improves the build time?

@jcordes73
Copy link
Author

Of course you need to override this "template" settings.xml with URLs pointing to your Maven repository (for example Nexus) that can act as a caching proxy as otherwise artifacts are always pulled from the internet when creating new apps.

@jcordes73
Copy link
Author

I just removed the enterprise repos ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants