Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update it to shouldShowDonateButton, logic #5076

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update it to shouldShowDonateButton, logic #5076

merged 1 commit into from
Nov 14, 2024

Conversation

l-olson1214
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T377899

Notes

  • Update logic to determine if webview should show donate button

Test Steps

  1. Fresh install, IT region, EN language
  2. Ensure 6+ articles in history, background and foreground app
  3. Navigate to year in review
  4. Press Learn More on first slide, ensure donate button does not show up in web view
  5. Navigate back to YIR, go to the "Wikipedia was edited X times" slide
  6. Press "Learn how to participate", ensure no donate button
  7. Navigate to the last slide and ensure if you have a donate history, no donate button shows. If you do not have a donate history, we'll want the button to show.
  8. Fake donate history or erase donate history to ensure both of the above work.

Screenshots/Videos

Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@tonisevener tonisevener merged commit 2650b2f into main Nov 14, 2024
5 checks passed
@tonisevener tonisevener deleted the T377899 branch November 14, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants