Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Metrics Part 2 #5070

Merged
merged 7 commits into from
Nov 14, 2024
Merged

[YiR] Metrics Part 2 #5070

merged 7 commits into from
Nov 14, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376302

Notes

This PR adds another set of metrics for year in review. Any additional instrumentation after this point will be done on a task-by-task basis (for example: https://phabricator.wikimedia.org/T376350 and https://phabricator.wikimedia.org/T379825)

Test Steps

  1. Temporarily update the WMFLogging.h value to DDLogLevelAll, so that we will see event payloads in the Xcode console.
  2. Observe the share button taps, closing donate slide button taps, and survey event payloads, and lightly confirm they look correct according to the deck. (Note: We can lean on QA and beta tester validation for more in-depth testing).

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team November 13, 2024 20:24
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mazevedofs mazevedofs merged commit 1fc5806 into main Nov 14, 2024
4 checks passed
@mazevedofs mazevedofs deleted the yir-metrics-2 branch November 14, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants