Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T375135 Lost location text in Places #5067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

T375135 Lost location text in Places #5067

wants to merge 1 commit into from

Conversation

rajparad
Copy link
Contributor

Phabricator:
https://phabricator.wikimedia.org/T375135

Notes

  • Issue was enable location dialog appears without the text below the enable button.
  • The issue was not that footerText was missing but footerText was not changing the styles based on theme due to updateFooterHTML() was not called.
  • After updating it, Footer text works with all Themes.

Test Steps

  1. Navigate to places
  2. View the enable location dialog

Screenshots/Videos

iPhone 12 white:
image

iPhone 12 Black theme:
image

iPad Pro Dark theme:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rajparad