Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Check username validity on text field return #4647

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/username-verification

b71acc7
Select commit
Loading
Failed to load commit list.
Draft

Feature: Check username validity on text field return #4647

Merge branch 'main' into feat/username-verification
b71acc7
Select commit
Loading
Failed to load commit list.
Xcode Cloud / Experimental | Wikipedia Experimental PR Build | Archive - iOS succeeded Nov 13, 2024 in 13m 46s

6 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 6

Details

6 Warnings

Details

  Wikipedia/Code/WMFAuthenticationManager.swift:388
      Immutable value 'appLanguage' was never used; consider replacing with '_' or removing it
  WMF Framework/Remote Notifications/RemoteNotificationsController.swift:113
      'catch' block is unreachable because no errors are thrown in 'do' block
  SwiftLint not installed, run "scripts/brew_install" script to install
  extractLocStrings:1
      Key "settings-donate" used with multiple comments "Link to donate" & "Title for button letting user make a donation."
  tasks in 'Copy Headers' are delayed by unsandboxed script phases; set ENABLE_USER_SCRIPT_SANDBOXING=YES to enable sandboxing
  WMFData/Sources/WMFData/Store/WMFCoreDataStore.swift:159
      Value 'sevenDaysAgoDate' was defined but never used; consider replacing with boolean test