-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch requested moves #1888
base: master
Are you sure you want to change the base?
Conversation
@@ -371,7 +371,7 @@ Morebits.quickForm.prototype.append = function QuickFormAppend(data) { | |||
* There is some difference on how types handle the `label` attribute: | |||
* - `div`, `select`, `field`, `checkbox`/`radio`, `input`, `textarea`, `header`, and `dyninput` can accept an array of items, | |||
* and the label item(s) can be `Element`s. | |||
* - `option`, `optgroup`, `_dyninput_element`, `submit`, and `button` accept only a single string. | |||
* - `option`, `optgroup`, `_dyninput_cell`, `submit`, and `button` accept only a single string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, what does _dyninput_cell do and why did its name change?
event: data.event | ||
event: data.event, | ||
inputs: data.inputs || [{ | ||
// compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding, what's going on with the compatibility sub-section here?
@@ -800,6 +785,41 @@ Morebits.quickForm.element.prototype.compute = function QuickFormElementCompute( | |||
removeButton.morebutton = data.morebutton; | |||
} | |||
break; | |||
case '_dyninput_cell': // Private, similar to normal input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my understanding, why did this case move down?
Fixes #1681