Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag: Adding {{Cleanup colors}} + {{Overcoloured}} #1857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lomrjyo
Copy link
Contributor

@lomrjyo lomrjyo commented Aug 30, 2023

will close #1847

@NovemLinguae
Copy link
Member

@lomrjyo. It looks like you created this PR on your fork's master branch instead of on its own branch. So I went to go edit it to make some changes but it didn't work. In the future, you can avoid this problem by creating your PRs on their own branches instead of the master branch.

So I can't make the changes for you. I'll leave them as code review comments instead. If you make the changes, I'll merge this.

Thanks for the patch.

@@ -903,6 +903,10 @@ Twinkle.tag.article.tagList = {
'Categories': [
{ tag: 'Improve categories', description: 'needs additional or more specific categories', excludeMI: true },
{ tag: 'Uncategorized', description: 'not added to any categories', excludeMI: true }
],
'Colors': [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to 'Accessibility'

@@ -903,6 +903,10 @@ Twinkle.tag.article.tagList = {
'Categories': [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut and paste both 'Categories' and 'Accessibility' so that they are in alphabetical order

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NovemLinguae, they have not been active for a year, so can I create a new PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure go ahead. If you can add a comment in your new PR reminding me to close this one, that'd be appreciated.

@DreamRimmer
Copy link

@NovemLinguae, new PR is #2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag: add {{Cleanup colors}} and {{Overcoloured}}
3 participants